Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maya: Validate Animation Out Set Related Node Ids improve report #266

Conversation

BigRoy
Copy link
Collaborator

@BigRoy BigRoy commented Mar 26, 2024

Changelog Description

Validate Animation Out Set Related Node Ids improve validation report message.

Note that it does have some additional changes:

  • Ignore nodes without ids - that is validated elsewhere
  • Only check specific types instead of excluding only locators (so that e.g. also constraints or deformers are excluded in the check)
  • Improve report message

Additional info

n/a

Testing notes:

  1. Loaded rigs (referenced) with additional deformers applied should work to publish animation for.
  2. Validator should work and be clear in messaging.

…report message

- Ignore nodes without ids - that is validated elsewhere
- Only check specific types instead of excluding only locators (so that e.g. also constraints or deformers are excluded in the check)
- Improve report message
@BigRoy BigRoy requested a review from LiborBatek March 26, 2024 21:59
@ynbot ynbot added host: Maya size/XS type: enhancement Improvement of existing functionality or minor addition labels Mar 26, 2024
@BigRoy
Copy link
Collaborator Author

BigRoy commented Mar 26, 2024

This sounds similar to #243 but is a different plug-in. :)

@MustafaJafar MustafaJafar added the community Issues and PRs coming from the community members label Mar 27, 2024
Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to produce animation even when deformer present on the rig....

seem working as expected....
image

didnt seen the new formatting of the messages tho

@BigRoy
Copy link
Collaborator Author

BigRoy commented Mar 27, 2024

I was able to produce animation even when deformer present on the rig....

seem working as expected.... image

didnt seen the new formatting of the messages tho

Sorry, my bad. Could you load a model product type, add a deformer, publish as pointcache product. You should hit the validator.

Since rigs already have deformers applied Maya doesn't "duplicate the shape without id" but just puts in the deformer in the deformation chain so it doesn't lose cbId on the shapes anyway.

Copy link
Member

@tokejepsen tokejepsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested successfully in Maya 2023.

@tokejepsen tokejepsen requested a review from LiborBatek March 29, 2024 08:34
Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All working fine...

first it properly validate that cbIDs missing on deformed shape and after Repair action all works and publish ok.

Screenshot 2024-03-29 100523 Screenshot 2024-03-29 100541

@LiborBatek LiborBatek merged commit cc8ebdd into ynput:develop Mar 29, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Issues and PRs coming from the community members host: Maya size/XS type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants