Unreal: Build shot structure from the database #25
Conversation
| @@ -590,21 +590,21 @@ def set_sequence_hierarchy( | |||
| hid_section.set_level_names(maps) | |||
|
|
|||
|
|
|||
| def generate_sequence(h, h_dir): | |||
| def generate_sequence(name, hierarchy_dir): | |||
| tools = unreal.AssetToolsHelpers().get_asset_tools() | |||
There was a problem hiding this comment.
Can we get a docstring for this function?
| sequence_root_name = "shots" | ||
|
|
||
| hierarchy = get_folders_hierarchy(project_name=project)["hierarchy"] | ||
|
|
||
| # Find the sequence root element in the hierarchy | ||
| sequence_root = next(( | ||
| element | ||
| for element in hierarchy | ||
| if element["name"] == sequence_root_name | ||
| ), None) |
There was a problem hiding this comment.
Is the requirement of there being a shots folder in the hierarchy an odd requirement maybe? Seems a bit hardcoded?
There was a problem hiding this comment.
So, yes, this is just a placeholder for now to get the functionality working, but there was discussion about creating a UI ad hoc to select which folder you want to create the shot structure for, so it's WIP :)
|
@BigRoy sorry, I forgot to set the PR as draft! It needs some more work! I will address all of of your points when I get back to work on this :) thanks as always for the inputs on these :D |
Co-authored-by: Roy Nieterau <[email protected]>
Co-authored-by: Jakub Trllo <[email protected]>
simonebarbieri
requested review from
BigRoy and
antirotor
and removed request for
BigRoy
There was a problem hiding this comment.
I need to go through it properly, but just quick first notes:
set_sequence_hierarchy() needs imho even better docstring. Or better names for arguments :) ... or both?
Like this usage:
set_sequence_hierarchy(
parents_sequence[i], parents_sequence[i + 1],
parents_frame_range[i][1],
parents_frame_range[i + 1][0], parents_frame_range[i + 1][1],
[level])
)I must admit I really don't know what is going on there.
Another point - since paths in UE are paths, we can use pathlib.Path on them so no need of .split("/") and stuff.
Also, some part are rather static, like get_default_sequence_path(settings). And I realize we tend to do it a lot in Unreal - expecting that something is always on specific path. I am glad that some of those paths can be now set in the settings - but we might later on (not in this PR) consider using actual anatomy templates there.
| PlaceholderLineEdit, | ||
| SquareButton, | ||
| ) | ||
| from ayon_core.tools.ayon_utils.widgets import ( |
There was a problem hiding this comment.
NOTE: This has changed to from ayon_core.tools.utils import SimpleFoldersWidget from this PR #195
|
when #614 is merged, we need to reopen it in https://github.com/ynput/ayon-unreal |
|
PR moved to ynput/ayon-unreal#4 |
Changelog Description
Added a button to build the shot structure as sequences from the database.
PR linked to ynput/OpenPype#6168