Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Headless publish failing without GL lib #228

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

antirotor
Copy link
Member

Changelog Description

The imports of openpype.tools.utils.host_tools.init.py were throwing an error due to trying to import QtWidgets unnecessarily.

Note

This is port of community PR to OpenPype - ynput/OpenPype#6205

Testing notes:

  1. Run a headless publish in a farm worker that doesn't have libGL

import qt related stuff only when using qt
@antirotor antirotor added the type: bug Something isn't working label Mar 25, 2024
@antirotor antirotor requested a review from iLLiCiTiT March 25, 2024 10:14
@antirotor antirotor self-assigned this Mar 25, 2024
@ynbot ynbot added the size/XS label Mar 25, 2024
@antirotor antirotor changed the title Update cli_commands.py Core: Headless publish failing without GL lib Mar 25, 2024
Copy link
Collaborator

@BigRoy BigRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Whether it also works as intended in Ayon would maybe be 'easy' to test by @fabiaserra ?

@iLLiCiTiT iLLiCiTiT merged commit 2f47d10 into develop Mar 25, 2024
10 checks passed
@iLLiCiTiT iLLiCiTiT deleted the bugfix/op-port-headless-publishing-import branch March 25, 2024 10:36
@iLLiCiTiT
Copy link
Member

iLLiCiTiT commented Mar 25, 2024

Sorry for quick merge, but it looked like there is nothing to thinkg about.

Question: Is the GUI option is still "valid"? Is it used anywhere?

@fabiaserra
Copy link
Contributor

Looks good to me.

Whether it also works as intended in Ayon would maybe be 'easy' to test by @fabiaserra ?

Yeah it's been working for me in my fork of OP addon for Ayon, I have this change already since a while back but I haven't taken the effort of migrating to ayon-core yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS type: bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants