Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fusion: Allow render publishes to have custom frame range per saver #225

Merged

Conversation

BigRoy
Copy link
Collaborator

@BigRoy BigRoy commented Mar 24, 2024

Changelog Description

Allow render publishes to have custom frame range per saver

Additional info

Screenshot:
image

There is currently no way to hide the 'custom frame range' attributes in the UI if the frame range source was not set to Custom Frame Range so it will always (confusingly) be shown. I know that is an issue @antirotor and @iLLiCiTiT are aware of but is currently in the backlog. I believe #134 is part of that as a tracked issue.


Note: It may potentially be that this does not work correctly for farm submitted renders - but if that's the case then I suspect that's also originally an issue with mixing the other "frame range sources" if they were different frame ranges. If that's indeed not working as intended, then that'd be a separate issue from this PR's functionality so would be great if you could report that as a separate issue if that's the case.

Testing notes:

  1. Create a few saver instances, say five different ones.
  2. Set them to different Frame Range Source
  3. Set two of them to "Custom frame range"
  4. Set different custom frame ranges

Each of the instances should render and publish only the specified frame ranges.

@BigRoy BigRoy requested a review from jakubjezek001 March 24, 2024 11:23
@ynbot ynbot added size/XS host: Fusion type: enhancement Improvement of existing functionality or minor addition labels Mar 24, 2024
@BigRoy
Copy link
Collaborator Author

BigRoy commented Mar 24, 2024

@EmberLightVFX I vaguely recall you were interested in this in the past, but I can't link you as reviewer.

@BigRoy BigRoy requested a review from LiborBatek March 24, 2024 11:25
@EmberLightVFX
Copy link
Contributor

Yes! I would actually need it for the project I'm currently working on 😄
Will try and test it out when I arrive to the office in two days!

@EmberLightVFX
Copy link
Contributor

Tried it out and works great.
The only problem I'm seeing is that the comp render ones per saver and not everything together. To solve this, when setting the Frame Start and Frame End we can change the in/out point of the node in question.
This would also be a great addition to with frame range set to From render in/out or From composition timeline that would set a custom render in/out point but that might be for another PR?

As on how the fusion integration currently works I would say this pr LGTM

@BigRoy
Copy link
Collaborator Author

BigRoy commented Mar 25, 2024

Tried it out and works great. The only problem I'm seeing is that the comp render ones per saver and not everything together. To solve this, when setting the Frame Start and Frame End we can change the in/out point of the node in question. This would also be a great addition to with frame range set to From render in/out or From composition timeline that would set a custom render in/out point but that might be for another PR?

As on how the fusion integration currently works I would say this pr LGTM

Actually - wait a second. How do you set a custom in/out point for a saver node so that that works? I never got that to work. But if we can render different frame ranges in one API call to "render" - yes please. Separate PR maybe, but yes - I'd like that!

@EmberLightVFX
Copy link
Contributor

EmberLightVFX commented Mar 25, 2024

Actually - wait a second. How do you set a custom in/out point for a saver node so that that works? I never got that to work. But if we can render different frame ranges in one API call to "render" - yes please. Separate PR maybe, but yes - I'd like that!

You just simply drag the in/out point of the saver node in the keyframes window. Fusion will then try and render the comp from your comps in/out points but as with any node, if it's not active on specific frames Fusion skips its processing, thus resulting in those frames not rendering out.
image

The only problem is that Fusion reports the render as failed if you try to render more frames than exists for an image-stream.
Eg you have a loaded sequence that goes from 1001 to 1011 that you try to render but your comp goes from 1001 to 1021.
Fusion will try to render but there is no image to render, thus the error.
I'll take a look at this for another PR and see if I can get it working as expected :)

@BigRoy
Copy link
Collaborator Author

BigRoy commented Mar 25, 2024

Eg you have a loaded sequence that goes from 1001 to 1011 that you try to render but your comp goes from 1001 to 1021.
Fusion will try to render but there is no image to render, thus the error.

I mean - that technically is a correct error then, yes? Or do you mean that if you use the saver's output downstream? (not sure if anyone does that?)

@EmberLightVFX
Copy link
Contributor

I mean - that technically is a correct error then, yes? Or do you mean that if you use the saver's output downstream? (not sure if anyone does that?)

Yes it is technically correct but at the same time it rendered correctly.
The problem ends up with fusion reporting that the render failed to the publisher even if it kind of didn't.

It's a bit complicated 😅

@BigRoy
Copy link
Collaborator Author

BigRoy commented Mar 25, 2024

It's a bit complicated 😅

Looking forward to the reported issue or even PR trying to target that! :)

I will try to help where I can.

Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did setup three different Render Saver instances with custom frame ranges and all published ok and with review mp4. All frame ranges matched those set on publish instances.

Works nicely!

image

@MustafaJafar MustafaJafar added the community Issues and PRs coming from the community members label Mar 26, 2024
@mkolar
Copy link
Member

mkolar commented Mar 27, 2024

happy to merge this. Regarding the in and out points, that's probably best for another PR

@jakubjezek001 jakubjezek001 merged commit e9e2d2e into ynput:develop Mar 27, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Issues and PRs coming from the community members size/XS type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants