-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fusion: Allow render publishes to have custom frame range per saver #225
Fusion: Allow render publishes to have custom frame range per saver #225
Conversation
@EmberLightVFX I vaguely recall you were interested in this in the past, but I can't link you as reviewer. |
Yes! I would actually need it for the project I'm currently working on 😄 |
Tried it out and works great. As on how the fusion integration currently works I would say this pr LGTM |
Actually - wait a second. How do you set a custom in/out point for a saver node so that that works? I never got that to work. But if we can render different frame ranges in one API call to "render" - yes please. Separate PR maybe, but yes - I'd like that! |
I mean - that technically is a correct error then, yes? Or do you mean that if you use the saver's output downstream? (not sure if anyone does that?) |
Yes it is technically correct but at the same time it rendered correctly. It's a bit complicated 😅 |
Looking forward to the reported issue or even PR trying to target that! :) I will try to help where I can. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
happy to merge this. Regarding the in and out points, that's probably best for another PR |
Changelog Description
Allow render publishes to have custom frame range per saver
Additional info
Screenshot:
There is currently no way to hide the 'custom frame range' attributes in the UI if the frame range source was not set to Custom Frame Range so it will always (confusingly) be shown. I know that is an issue @antirotor and @iLLiCiTiT are aware of but is currently in the backlog. I believe #134 is part of that as a tracked issue.
Note: It may potentially be that this does not work correctly for farm submitted renders - but if that's the case then I suspect that's also originally an issue with mixing the other "frame range sources" if they were different frame ranges. If that's indeed not working as intended, then that'd be a separate issue from this PR's functionality so would be great if you could report that as a separate issue if that's the case.
Testing notes:
Each of the instances should render and publish only the specified frame ranges.