Re-add outputName to _rename_in_representation #219
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
This PR simply adds
new_repre["outputName"] = output_name
inside the_rename_in_representation
function.Without this if a user would like to add eg {colorspace} to a name preset it wouldn't be found, so you can't have two oiio outputs as the second one would try and overwrite the first publish.
Additional info
This bug was found by @jakubjezek001 under the hackinton but I'm submitting it as we fixed in on my ayon instance.
Testing notes:
Without this fix you'll get an error that it can't publish an already published product. With the fix + _{colorspace} added to the name Ayon will be able to publish the new oiio products with new correct output names.