Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add outputName to _rename_in_representation #219

Conversation

EmberLightVFX
Copy link
Contributor

Changelog Description

This PR simply adds new_repre["outputName"] = output_name inside the _rename_in_representation function.
Without this if a user would like to add eg {colorspace} to a name preset it wouldn't be found, so you can't have two oiio outputs as the second one would try and overwrite the first publish.

Additional info

This bug was found by @jakubjezek001 under the hackinton but I'm submitting it as we fixed in on my ayon instance.

Testing notes:

  1. add <_{colorspace}> to your render name preset
  2. add two oiio conversion presets
  3. publish a render

Without this fix you'll get an error that it can't publish an already published product. With the fix + _{colorspace} added to the name Ayon will be able to publish the new oiio products with new correct output names.

@ynbot ynbot added type: enhancement Improvement of existing functionality or minor addition size/XS labels Mar 23, 2024
@MustafaJafar MustafaJafar added the community Issues and PRs coming from the community members label Mar 25, 2024
Copy link
Member

@jakubjezek001 jakubjezek001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic! @EmberLightVFX Thanks

@jakubjezek001 jakubjezek001 merged commit 8f0475c into ynput:develop Mar 26, 2024
5 checks passed
@EmberLightVFX EmberLightVFX deleted the enhancement/re-add_outputName_to_rep branch April 18, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Issues and PRs coming from the community members size/XS type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants