Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blender: Validate Transform Zero report + repair #215

Conversation

BigRoy
Copy link
Collaborator

@BigRoy BigRoy commented Mar 20, 2024

Changelog Description

Validate Transform Zero report + repair improve validation report + add repair actionpair action

Additional info

n/a

Testing notes:

  1. Publish model with transforms on objects
  2. Validation report should be clear
  3. Repair action should work

@ynbot ynbot added size/XS type: enhancement Improvement of existing functionality or minor addition host: Blender labels Mar 20, 2024
Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It correctly validates when any sort of transform present but it fails on Repair action which doesnt repair aka apply the transforms to deltas.

I have found that if I use first Select Invalid and then Repair action then it works well.
I guess we should adjust so it works in both cases when the model being first selected (as it works in this condition) and also if not selected....which do not work atm.
image

@BigRoy
Copy link
Collaborator Author

BigRoy commented Mar 24, 2024

@LiborBatek thanks - should be fixed now with 5b0826a

Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now all works in both cases...I havent spot any issues this time.

Good to go!

@LiborBatek LiborBatek merged commit 04b334d into ynput:develop Mar 25, 2024
5 checks passed
@BigRoy BigRoy deleted the enhancement/blender_validate_transform_zero_repair branch March 27, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants