Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Fix last versions getters for ayon api #211

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

iLLiCiTiT
Copy link
Member

@iLLiCiTiT iLLiCiTiT commented Mar 20, 2024

Changelog Description

Monkey patch ayon api functions to fix issue with get last verisons.

Additional info

Last versions getter are also returning hero version which lead to invalid resolving of latest version. This will be fixed in next release of ayon python api but until that point the methods are monkey patched (ayon-api PR).

Testing notes:

  1. Scene inventory should show correctly latest version if there is hero version.

Copy link
Collaborator

@BigRoy BigRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes #202 for me.

Also fixes updating to latest in scene inventory 'switching' to hero version.

@LiborBatek LiborBatek self-requested a review March 20, 2024 17:17
Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me and working as expected...

Screenshot 2024-03-20 181613

After update to latest... I have also tried switching versions back and forth without any issues. So all fine!
Screenshot 2024-03-20 181706

@iLLiCiTiT iLLiCiTiT merged commit 47cb00b into develop Mar 21, 2024
7 checks passed
@iLLiCiTiT iLLiCiTiT deleted the bugfix/monkey-patch-ayon-api-last-version branch March 21, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants