Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create: Add missing variable 'task_name' #199

Merged
merged 2 commits into from
Mar 19, 2024
Merged

Create: Add missing variable 'task_name' #199

merged 2 commits into from
Mar 19, 2024

Conversation

iLLiCiTiT
Copy link
Member

Changelog Description

Handled case when task_entity in create method is None.

Testing notes:

  1. Create object of CreateContext and run create method without task entity.
  2. It should not crash because of missing task_name variable.

@iLLiCiTiT iLLiCiTiT requested a review from jakubjezek001 March 19, 2024 14:15
@ynbot ynbot added size/XS type: bug Something isn't working labels Mar 19, 2024
@jakubjezek001
Copy link
Member

could we also update the docstring for the Create function.

@iLLiCiTiT
Copy link
Member Author

could we also update the docstring for the Create function.

Done

@iLLiCiTiT iLLiCiTiT merged commit 74916e3 into develop Mar 19, 2024
2 checks passed
@iLLiCiTiT iLLiCiTiT deleted the bugfix/missing-variable-in-create branch March 19, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubjezek001 jakubjezek001 jakubjezek001 approved these changes

Assignees

@jakubjezek001 jakubjezek001

Labels
size/XS type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iLLiCiTiT @jakubjezek001 @ynbot