Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve: Adjust clip start if slate is present #149

Merged
merged 2 commits into from
Mar 6, 2024
Merged

Resolve: Adjust clip start if slate is present #149

merged 2 commits into from
Mar 6, 2024

Conversation

jakubjezek001
Copy link
Member

Changelog Description

Starting of clip should be adjusted if slate frame is detected.

Additional info

Originally submitted here ynput/OpenPype#6126

Testing notes:

  1. in Resolve load into the timeline representation with slate
  2. Slate should be trimmed out

@jakubjezek001
Adjust clip start if slate is present
fd8bf2c 
Trim the clip's start time by 1 frame and update its duration accordingly when a "slate" is detected in the version data families. Also, corrected calculation for `frame_end_handle` to use `frame_end`.
@ynbot ynbot added size/XS type: bug Something isn't working host: Resolve labels Mar 6, 2024
@jakubjezek001
Copy link
Member Author

@jrsndl here is the alternative on ayon-core.

jakubjezek001
jakubjezek001 commented Mar 6, 2024
View reviewed changes
Copy link
Member Author

@jakubjezek001 jakubjezek001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was adapted originally from OpenPype Repo and I was testing it in both and it is working, so strangely although I am author of this PR I am approving it and merging it as well ;)

@jakubjezek001 jakubjezek001 merged commit 7bf7780 into develop Mar 6, 2024
2 checks passed
@jakubjezek001 jakubjezek001 deleted the bugfix/AY-1684_Bug-Resolve-Clip-Load-doesnt-support-Slate branch March 6, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-u-r-p-h-y m-u-r-p-h-y Awaiting requested review from m-u-r-p-h-y

@64qam 64qam Awaiting requested review from 64qam

@LiborBatek LiborBatek Awaiting requested review from LiborBatek

Assignees

@LiborBatek LiborBatek

Labels
host: Resolve size/XS type: bug Something isn't working
Projects
PR reviewing
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jakubjezek001 @ynbot @LiborBatek