Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Max: Validate Mesh Has UVs #121

Merged
merged 14 commits into from
Mar 1, 2024
Merged

Conversation

moonyuet
Copy link
Member

Changelog Description

This PR is to add the validator to check mesh has UVs in model product type.

Additional info

n/a

Testing notes:

  1. Install the latest Max Addon
  2. Launch Max via AYON
  3. Create Model Instance with some meshes
  4. Turn on Validate Mesh Has UVs in Publish Tab
  5. If the mesh does not have UVs, the validator errors out.

@moonyuet moonyuet requested a review from LiborBatek February 27, 2024 11:29
@ynbot ynbot added type: enhancement Improvement of existing functionality or minor addition host: 3dsmax size/XS labels Feb 27, 2024
@moonyuet moonyuet requested a review from antirotor February 27, 2024 11:30
@moonyuet moonyuet requested a review from BigRoy February 27, 2024 13:35
@moonyuet moonyuet requested a review from BigRoy February 28, 2024 09:54
@moonyuet moonyuet requested a review from BigRoy February 28, 2024 12:45
@moonyuet moonyuet requested a review from BigRoy February 29, 2024 07:10
Copy link
Collaborator

@BigRoy BigRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After the last comment I think this should be good.

Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When setting the Validator for UVs it correctly kicks in during Publishing of a model
Screenshot 2024-03-01 095949

when UVs are missing:

Screenshot 2024-03-01 095236

And if any sort of UVs applied (also just on selected only faces of the object) then it Validates ok and publish will succeed correctly...
Screenshot 2024-03-01 095732

@moonyuet moonyuet merged commit 01bbf8e into develop Mar 1, 2024
@moonyuet moonyuet deleted the enhancement/OP-7078_ValidateMeshHasUVs branch March 1, 2024 09:05
@BigRoy
Copy link
Collaborator

BigRoy commented Mar 1, 2024

Screenshot 2024-03-01 095732

Side note and not part of this PR: Just wanted to say that the Validating model content for modelMain should not be a info level log. The artist doesn't care that the validation is happening - they only need to know about data that might not be obvious or they want to double check OR any issues. This should thus be a debug log.

The project context at the top however is useful for artists however since it confirms for them that they were in the correct context, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
host: 3dsmax size/XS type: enhancement Improvement of existing functionality or minor addition
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants