-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: Product name and type #113
Chore: Product name and type #113
Conversation
…ductType # Conflicts: # client/ayon_core/hosts/nuke/api/lib.py # client/ayon_core/hosts/nuke/api/plugin.py
client/ayon_core/hosts/blender/plugins/publish/extract_blend_animation.py
Outdated
Show resolved
Hide resolved
client/ayon_core/hosts/blender/plugins/publish/extract_camera_fbx.py
Outdated
Show resolved
Hide resolved
client/ayon_core/hosts/blender/plugins/publish/extract_fbx_animation.py
Outdated
Show resolved
Hide resolved
client/ayon_core/hosts/blender/plugins/publish/extract_playblast.py
Outdated
Show resolved
Hide resolved
client/ayon_core/hosts/blender/plugins/publish/extract_thumbnail.py
Outdated
Show resolved
Hide resolved
…tibility. Remove redundant code and improve data assignment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested it in Houdini and it works.
Few notes for reference.
Note 1:
It'd be better to prefix all parameters as you and @BigRoy mentioned here #115 (comment) . I think we can do it in another PR as the current status doesn't conflict with the implemented product types.
Note 2:
I faced few bugs but I think they are not related to this PR as I was able to replicate them in develop branch.
- Publish Image sequence (for some reason, representation data are empty)
- Loading HDAs from Loader (where Loader fetches the wrong version)
Hiero and Resolve works! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested in 3dsmax and substance painter. So far so good.
Traypublisher's Simple EDL editorial works like a charm ;) |
Traypublisher's Simple Creators works too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blender and Unreal works. There are a few issues in Unreal, but unrelated to this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've hit issue when publishing renders from maya, but it doesn't seem to be connected to this PR. So fo me and Maya 👍🏻
Changelog Description
Goal of this PR is to start using product naming in code base. Which means to use
productName
andproductType
instead ofsubset
andfamily
during create and publish phase.Additional info
First of all I'm 100% sure that I broke something, if you can, please do code review first before you try to run. If you find any issues please report as soon as possible, you can DM me with quick questions.
All changes should support compatibility with workfiles before this PR in all hosts.
All the time when a
family
did represent product type, it should be changed toproduct type
. e.g. create plugin does haveproduct_type
instead offamily
and created instance hasproductType
in data instead offamily
.One of the goals was to also use
productType
instead offamily
during publishing and use onlyfamilies
for pyblish filtering. The keyfamily
key is filled by pyblish automaticlly to"default"
, so it should not be an issue. But when we planned it, we didn't realize that sometimesinstance.data
are filled with raw data from scene, and in that case there might befamily
with a value that is not managed by us, speaking only about logic or workfiles with instances before this PR. I've changed that idea and all the timeproductType
is changed during publishing,family
is changed too.What I couldn't resolve
Json files in Blender and Unreal
Sometimes it looks like the json is storing data that are unused, and sometimes I couldn't find source of their data so I couldn't tell if/how should I modify them. Sometimes the data are stored unclearly under key that says nothing about the value, e.g. json has
"_id"
which in fact represents representation id. Some of the json files are storingfamily
which should be probably changed toproduct_type
but I didn't find where the value is used. etc.Json files in Maya
This is just about looks publishing, needs validation that I didn't break anything.
Resolve and Hiero
I probably failed at backwards compatibility.
Testing notes:
CelactionFlameHarmonyNote: This PR is clashing Hiero integration PR #87