AY-6502_Fix Maya dirmap settings #1061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only other integration I can see that has dirmapping is Nuke, which uses just `dirmap` without host prefix - which I suppose would then be broken regardless. It may make more sense to remove the `host` specific prefix from the label because it's already looking in host specific settings anyway.
BigRoy
added
the
sponsored
iLLiCiTiT
reviewed
Dec 17, 2024
|
Task linked: AY-6502 dirmap not working |
moonyuet
approved these changes
Dec 30, 2024
iLLiCiTiT
approved these changes
Dec 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
Remove host name separator in dirmap settings, so that Maya settings
maya_dirmapormaya-dirmapis nowdirmapinside that host's settings.Additional info
Only other integration I can see that has dirmapping is Nuke, which uses just
dirmapwithout host prefix - which I suppose would then be broken regardless anyway but I think it uses its own way of remapping paths. It may make more sense to remove thehostspecific prefix from the label because it's already looking in host specific settings anyway. (However, that'd also need a refactor inayon-mayathen? Plus it would then also suddenly pick up the Nuke one which may have other side effects?Reported on discord here
Nuke and Maya seems to be the only repos relevant to
dirmap.Fixes ynput/ayon-maya#102
Testing notes: