Loader & Scene inventory: Ignore containers with invalid representation id #1037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nvalid-dataschema-with-a-warning-instead-of-error
iLLiCiTiT
deleted the
bugfix/788-tools-ignore-containers-with-invalid-dataschema-with-a-warning-instead-of-error
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
Loader and scene inventory should not cause issues when container in scene contains invalid representation id.
Additional info
Capture all possible errors when validating representation ids. In case of Loader tool, we really need only the representation ids and we don't care about anything else. In scene inventory already happens some validation of the data. The validation does not fully preserve issues, but that probably should not be job of the tool.
Partially resolves #788 . The issue is more aboud full validation of container data, which might be actually production breaking change at this moment as we don't enforce container schema now. And it might be more work than a simple capture of unhandled exceptions. We do miss a lot of load related api, which is epic on it's own.
Testing notes:
None) does not break tools.