Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Use folder path in current context #103

Merged
merged 3 commits into from
Feb 27, 2024

Conversation

iLLiCiTiT
Copy link
Member

Changelog Description

Use folder_path instead of asset_name in current context and context data.

Additional info

This is minimalistic PR changing just the keys used when data for context are read or defined.

Breaks backwards compatibility on current context data and launch hooks. Launch hooks don't have access to asset_name in data.

Testing notes:

  1. Application can launch on a context.
  2. Change of context with workfiles too triggers correct callbacks without issues.

Copy link
Member

@tokejepsen tokejepsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in Nuke 15 successfully.

Could we maybe get some checkboxes for the hosts in the description?

@MustafaJafar
Copy link
Contributor

MustafaJafar commented Feb 26, 2024

In Houdini, I faced two things:

  1. Publisher tab looks like this: can't replicate it anymore.. maybe it was an issue with my network.
    image

  2. Sometimes context change works and sometimes it fails. I was able to replicate it in develop branch.. Not, related to this PR.
    image

@iLLiCiTiT
Copy link
Member Author

iLLiCiTiT commented Feb 27, 2024

Sometimes context change works and sometimes it fails.

Any traceback? Is the fail related to how the context is changed?

Is it related to this PR? I can't debug this as I don't have Houdini, and I have no direction what could be wrong.

Copy link
Member

@jakubjezek001 jakubjezek001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works in nuke

@iLLiCiTiT
Copy link
Member Author

For anyone reading this PR in future. The issues with publisher did not happen again, probably was caused by lost connection to server, and the context change issue in houdini is not related to this PR.

@iLLiCiTiT iLLiCiTiT merged commit 3dd124a into develop Feb 27, 2024
7 checks passed
@iLLiCiTiT iLLiCiTiT deleted the enhancement/OP-8316_Use-folder-in-current-context branch February 27, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
host: Houdini host: Nuke size/S type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants