Loader UI: Don't change selection on version combobox hover #1008
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LiborBatek
approved these changes
Nov 12, 2024
…-upon-just-hover-over-version-column
iLLiCiTiT
deleted the
bugfix/1007-loader-tool-selection-changes-upon-just-hover-over-version-column
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
Product/version selection does not change on hover over version combobox.
Additional info
It looks like views do change selection based on focus and having available editor widget. It skips that logic if editor has
NoFocuspolicy. Based on documentation they should have set focus policy tiNoFocusas we don't want to be able to "focus" into the widget.Testing notes:
Resolves #1007