Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing instance of BlenderScene won't remove the scene assets. #83

Merged

Conversation

moonyuet
Copy link
Member

Changelog Description

This PR is to fix the bug of removing BlenderScene instance also deleting the included asset inside it.
Resolve #61

Additional review information

n/a

Testing notes:

  1. Create BlenderScene Instance with your assets
  2. Removing it

@moonyuet moonyuet requested a review from LiborBatek December 10, 2024 10:24
@moonyuet moonyuet self-assigned this Dec 10, 2024
@moonyuet moonyuet added the type: bug Something isn't working label Dec 10, 2024
@moonyuet moonyuet requested a review from BigRoy December 10, 2024 10:24
Copy link
Contributor

@BigRoy BigRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see how and why this works - admittedly though, I feel like this does the exact opposite of what I expect would happen. I would instead expect the objects that are IN the instance to remain existing within the Blender scene and not ONLY live in the Blender Scene instance. It acts solely as an object set / container. Right?

Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It partially resolve the issue and do not remove the objects/geometries once deleting publish instance blendScene but it is not removing also the Collection used for the publishing as seen on pic below:

Screenshot 2024-12-10 130927

so the instance is removed from the Publisher UI only and once refreshing it or creating new publish instance blendScene is leading to duplication and creation of another instance with 001 appendix. as seen below, which is undesirable.

Screenshot 2024-12-10 131024

We have to got rid of everything AVALON_INSTANCES related besides the actual scene objects aka user created content (e.g. models etc)

Copy link
Contributor

@BigRoy BigRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test - but code seems fine to me.

Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now all works as expected! All good...

@moonyuet moonyuet merged commit 5986894 into develop Dec 11, 2024
1 check passed
@moonyuet moonyuet deleted the bugfix/remove_instance_for_blenderScene_product_type branch December 11, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Removing "BlendScene" publish instance in the Publisher via trash icon removes the actual asset(s)
3 participants