The AOVs from render layer nodes always connected to the Output File Node

[moonyuet]

Changelog Description

This PR is to make sure the AOVs from render layer nodes always connected to the Output File Node.
Resolve #37

Additional review information

n/a

Testing notes:

1. Add some render settings in Ayon server
2. Create Render Instance with your camera
3. Publish

[LiborBatek]

It does work when single Viewlayer present (render layer but in Blender terms)

the graph is correct when just one layer present>

but create Render fails and doesnt connect to file output node for the second Viewlayer as seen below (it fails and wrongly connects to file output node)...

[LiborBatek]

Ideally it should be behaving like this mockup I created manually:

and it does follow ayon-blender addon settings:
in my case:

[LiborBatek]

@moonyuet it still does not work and to me it seems that it does not take the ViewLayers present into account at the collecting phase as it should propagate AOVs set in the blender addon settings and turn those on automatically but this just happens on the default first ViewLayer and not any other present e.g, Layer2 in my case...

Ideally we should first collect any ViewLayers,create Render Layers node first for respective Viewlayer (as there is just single node when using compositor for very first time) , then check if AOVs set according to addons setting and lastly connect those to the file output node.

Im really not aware how much of this we already have in place (in terms of code) and which parts we miss completely atm...

[LiborBatek]

Its getting better and better... now we have correct subpaths for each ViewLayer and also layer name included within filename which is good and desirable!

Now there are 2 more issues found:

1. When having set some AOVs in the AYON addons settings, those are just propagated to the very first ViewLayer and not any other
   

2. when user does not create Scene node manually to introduce new additional ViewLayer.001 in Composite tree, AYON does not pick it up and just ignores the fact there is additional viewlayer(s) within the scene and uses just the default ViewLayer and use this for File Output node...

So if setting all manually I am able to get the desired node tree with proper outputs for any ViewLayer present in the scene... like on the following scrn:

And lastly (for consideration) is the limitation comming with the way we prepare AOVs via Addons settings...

as now if user have some AOVs turned on within his blender scene and triggers creation of Render instance it follows the addons settings so if no any matching AOVs present it will just remove any present AOVs - basically destroying all present AOV setups...

[LiborBatek]

So here is example when Ayon addons settings have empty AOVs fields (to create):

Before:

After triggering Create > Render

We should probably think about approach that when no AOVs preconfigured, it wont force remove any existing AOV s during creation of Render instance... not destroying any user config within workfile.

[LiborBatek]

My findings so far:

When defining AOVs in addons settings just the AovName(CyclesOnly) been picked up.... as seen on my following 2 scrns. The good thing is, when have it empty (aka no AOVs configured) it wont delete any scene AOVs set by user, which is great!

Another finding, when add additional ViewLayer and hit create for Render publish instance, Blender freeze and could not be operated then...seems like some crash happening (no any log tho).

[LiborBatek]

So I have made another testing round with following findings:

1. now all AOVs got propagated from addons settings into blender once hitting create>Render

2. unfortunatelly it also removes any existing AOVs during creation - big no no.

3. Blender freezes if more then one Scene node present when hitting create>Render instance (only when present tho see img below)

if just single Scene node present and more than one ViewLayer present it doesnt freeze and sort of works...

there is a however issue that it multiplies even the already present Scene node which is not desirable as it mixes up connections to File Output node and results into duplicate outputs...

We should check if any Scene nodes already exists in the scene...to not create redundant ones...as seen here:

[LiborBatek]

Now all works really well and been tested in different conditions...

single / multiple ViewLayers, present / absent AOVs and full / empty AOVs preset in Addons Settings - seem all working nicely!

If any issue then there is one questionable thing regarding the Compositing aov...as there always exists just single node tree and output.

Right now there is created input for composite for each ViewLayer which results into multiplied inputs and also empty ones (as only the first ViewLayer got connected)

We should introduce some logic and create/hook just the very first ViewLayer I guesss (it happens atm but there are also redundant other composite inputs which results into blank images and we shouldnt ideally create those at all)...cant think now if any occasion that might not be working with it...

[LiborBatek]

After another testing round now there is just single Composite input into File Output node which is correct!

Also no any freeze of Blender happening if scene compositor pre occupied with multiple Scene nodes...also good!

There is only one flaw regarding the Composite AOV and that is created as an output for non default ViewLayer but for ViewLayer.001 minor flaw but we should use that default viewLayer instead...

Other than that all good!

[LiborBatek]

Now gives me following error after hit Create > Render

Traceback (most recent call last):
  File "C:\Users\lbate\AppData\Local\Ynput\AYON\addons\core_1.0.12+dev\ayon_core\pipeline\create\context.py", line 2126, in _create_with_unified_error
    result = creator.create(*args, **kwargs)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\lbate\AppData\Local\Ynput\AYON\addons\blender_0.2.7+dev\ayon_blender\plugins\create\create_render.py", line 28, in create
    prepare_rendering(collection)
  File "C:\Users\lbate\AppData\Local\Ynput\AYON\addons\blender_0.2.7+dev\ayon_blender\api\render_lib.py", line 422, in prepare_rendering
    aov_file_product = set_node_tree(
                       ^^^^^^^^^^^^^^
  File "C:\Users\lbate\AppData\Local\Ynput\AYON\addons\blender_0.2.7+dev\ayon_blender\api\render_lib.py", line 308, in set_node_tree
    output.base_path = render_product if multi_exr else str(output_path)
    ^^^^^^^^^^^^^^^^
TypeError: bpy_struct: item.attr = val: CompositorNodeOutputFile.base_path expected a string type, not list

[LiborBatek]

Now all seems correct and Render instance got created without any issues, also all inputs got connected into File Output node and only main aka default ViewLayer got outputted its Composite so all good on this front too..

there is one thing worth noting and that is Repair action for Output folder mess up the node tree and disconnects some inputs... probably not directly related but need to be resolved otherwise the setup will be broken as soon as triggering the repair action by user.

Resulting into following (note the File Output and disconnected inputs):