Events: Reusable events #310
Open
+105
−56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martastain
added
the
type: enhancement
iLLiCiTiT
reviewed
Dec 5, 2024
Co-authored-by: Jakub Trllo <[email protected]>
iLLiCiTiT
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces an optional
reuse: bool = Falseparameter to theEventStream.dispatchfunction. When set to True, if an event with the same hash already exists in the event stream, the existing event will be updated, and its ID will be returned instead of raising an exception.This enhancement simplifies scenarios where previously it was necessary to first query the event by its hash and, only if it was not found, create a new one.
As a demonstration of this new functionality, the handling of the
addon.installevent has been refactored to leverage the reuse parameter.