This repository has been archived by the owner on Oct 10, 2024. It is now read-only.
Add validator to check correct version of extension for PS and AE #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e/OP-2019_Create-test-publish-class-for-AE
…feature/OP-2053_Add-validator-to-check-correct-version-of-extension-for-PS-and-AE
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| } | ||
| } | ||
| } | ||
| return version |
| 'text/xml'); | ||
| const children = xmlDoc.children; | ||
|
|
||
| for (let i = 0; i <= children.length; i++) { |
There was a problem hiding this comment.
'let' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
| const parser = new DOMParser(); | ||
| const xmlDoc = parser.parseFromString(result.data.toString(), | ||
| 'text/xml'); | ||
| const children = xmlDoc.children; |
There was a problem hiding this comment.
'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
| if(result.err === 0){ | ||
| if (window.DOMParser) { | ||
| const parser = new DOMParser(); | ||
| const xmlDoc = parser.parseFromString(result.data.toString(), |
There was a problem hiding this comment.
'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
| var version = undefined; | ||
| if(result.err === 0){ | ||
| if (window.DOMParser) { | ||
| const parser = new DOMParser(); |
There was a problem hiding this comment.
'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
| log.debug("extension path " + path); | ||
|
|
||
| var result = window.cep.fs.readFile(path + "/CSXS/manifest.xml"); | ||
| var version = undefined; |
There was a problem hiding this comment.
It's not necessary to initialize 'version' to 'undefined'.
| @@ -28,6 +28,33 @@ async function startUp(url){ | |||
| main(res); | |||
| } | |||
|
|
|||
| function get_extension_version(){ | |||
| /** Returns version number from extension manifest.xml **/ | |||
| log.debug("get_extension_version") | |||
| } | ||
| } | ||
| } | ||
| return version |
64qam
approved these changes
Dec 14, 2021
kalisp
deleted the
feature/OP-2053_Add-validator-to-check-correct-version-of-extension-for-PS-and-AE
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires ynput/OpenPype#2387
Contains also #391 which should be merged first.