This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 129
Hiero collecting and processing review #720
Merged
mkolar
merged 12 commits into
feature/611-simplify-hiero-tag-workflow
from
feature/hiero-publishing-review
Nov 20, 2020
Merged
Hiero collecting and processing review #720
mkolar
merged 12 commits into
feature/611-simplify-hiero-tag-workflow
from
feature/hiero-publishing-review
Nov 20, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakubjezek001
added
type: enhancement
Enhancements to existing functionality
host: Hiero
2x-dev
labels
Nov 17, 2020
jakubjezek001
changed the base branch from
feature/611-simplify-hiero-tag-workflow
to
feature/hiero-apply-colorspace-from-preset
November 17, 2020 19:12
jakubjezek001
force-pushed
the
feature/hiero-apply-colorspace-from-preset
branch
from
November 18, 2020 12:46
ae2d058
to
7ea1eca
Compare
also collect colorspace to workfile instance
jakubjezek001
force-pushed
the
feature/hiero-publishing-review
branch
from
November 18, 2020 13:01
a91a8d7
to
cabbc53
Compare
jakubjezek001
changed the base branch from
feature/hiero-apply-colorspace-from-preset
to
feature/611-simplify-hiero-tag-workflow
November 20, 2020 11:59
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
!! READ THIS PLEASE !!
This PR needs to be merged into
feature/hiero-apply-colorspace-from-preset
or afterfeature/hiero-apply-colorspace-from-preset
is merged intofeature/611-simplify-hiero-tag-workflow
it could be retargeted intofeature/611-simplify-hiero-tag-workflow
hiero
hostThree ways of testing:
1. review clip is long clip cowering most of clips from a main track:
In this case the main track is
main
and review track calledreview
2. review clip is the same clip length as the main track clips:
Reveiw clips are allign with main clip
3. review clips can be either of previous two ways, either video or image sequences: