Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Hiero collecting and processing review #720

Merged

Conversation

jakubjezek001
Copy link
Member

@jakubjezek001 jakubjezek001 commented Nov 17, 2020

!! READ THIS PLEASE !!
This PR needs to be merged into feature/hiero-apply-colorspace-from-preset or after feature/hiero-apply-colorspace-from-preset is merged into feature/611-simplify-hiero-tag-workflow it could be retargeted into feature/611-simplify-hiero-tag-workflow

  • creating review track with list option in creator ui - default is None
  • collection of review clip and connecting it to main track clip
  • reworking global plugins which are keeping backward compatibility for other then hiero host
  • fixing problem with collect assetbuild plugin
  • improving a way collect instances are returning selected or not selected clips on timeline. If nothing is selected it will return all clips tagged with publishable tag. If some clips are selected it will try to find publishable tag in them and create instances

Three ways of testing:

1. review clip is long clip cowering most of clips from a main track:

In this case the main track is main and review track called review
image

2. review clip is the same clip length as the main track clips:

Reveiw clips are allign with main clip
image

3. review clips can be either of previous two ways, either video or image sequences:

image

@jakubjezek001 jakubjezek001 added type: enhancement Enhancements to existing functionality host: Hiero 2x-dev labels Nov 17, 2020
@jakubjezek001 jakubjezek001 requested a review from a team November 17, 2020 19:09
@jakubjezek001 jakubjezek001 self-assigned this Nov 17, 2020
@jakubjezek001 jakubjezek001 changed the base branch from feature/611-simplify-hiero-tag-workflow to feature/hiero-apply-colorspace-from-preset November 17, 2020 19:12
@jakubjezek001 jakubjezek001 force-pushed the feature/hiero-apply-colorspace-from-preset branch from ae2d058 to 7ea1eca Compare November 18, 2020 12:46
@mkolar
Copy link
Member

mkolar commented Nov 19, 2020

Seem to be having some problem collecting (sq01sh050 doesn't exist yet in the database btw )
image

@mkolar
Copy link
Member

mkolar commented Nov 19, 2020

When I use review track as advised it starts collecting, but here are the errors I get.
image
image
image
image

@jakubjezek001 jakubjezek001 changed the base branch from feature/hiero-apply-colorspace-from-preset to feature/611-simplify-hiero-tag-workflow November 20, 2020 11:59
@mkolar mkolar merged commit 966f4cf into feature/611-simplify-hiero-tag-workflow Nov 20, 2020
@mkolar mkolar deleted the feature/hiero-publishing-review branch December 1, 2020 15:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
host: Hiero type: enhancement Enhancements to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants