This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Changes in
pype.lib._subprocess
sdterr
usesubprocesss.PIPE
instead ofsubprocesss.stdout
to be able separate them fromprocess.communication()
RunTimeError
instead ofValueError
if subprocess ends with nonzero returncodeExtractReview
&ExtractBurnin
plugins_subprocess
and are passing logger to it so they do not have to care about logging outputburnin script
resolve #640