Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Burnin script logs better output #641

Merged
merged 15 commits into from
Oct 16, 2020
Merged

Conversation

iLLiCiTiT
Copy link
Member

@iLLiCiTiT iLLiCiTiT commented Oct 15, 2020

Changes

  • Changes in pype.lib._subprocess

    • all changes should be backwards compatible
    • it is possible to pass logger object (handy in pyblish plugins)
    • Popen subprocess sdterr use subprocesss.PIPE instead of subprocesss.stdout to be able separate them from process.communication()
    • returns whole output of executed process, concatenated stdout and stderr
    • raises RunTimeError instead of ValueError if subprocess ends with nonzero returncode
    • is logging whole stdout at once and stderr at once, instead of line by line
      • line by line spams MongoDB and it is easier to read output from single
      • stdout is logged as debug level
      • stderr is logged as warning level
  • ExtractReview & ExtractBurnin plugins

    • are using new changes in _subprocess and are passing logger to it so they do not have to care about logging output
  • burnin script

    • removed loglevel from ffmpeg command so whole output from ffmpeg is accesible
    • output of ffmpeg process is actually catched and printed

resolve #640

@iLLiCiTiT iLLiCiTiT self-assigned this Oct 15, 2020
@iLLiCiTiT iLLiCiTiT requested a review from a team October 15, 2020 14:44
@mkolar mkolar changed the title Burnin script output Burnin script logs better output Oct 16, 2020
@mkolar mkolar added backend type: enhancement Enhancements to existing functionality labels Oct 16, 2020
@mkolar mkolar added this to the 2.13 milestone Oct 16, 2020
@mkolar mkolar merged commit a9aff3b into release/2.13.0 Oct 16, 2020
@mkolar mkolar added type: bug Something isn't working and removed type: enhancement Enhancements to existing functionality labels Oct 18, 2020
@mkolar mkolar deleted the feature/burnin_script_output branch October 18, 2020 21:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants