Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Maya: Correct Alembic export defaults AY-5273 #6268

Merged
merged 3 commits into from
Jun 12, 2024
Merged

Conversation

tokejepsen
Copy link
Member

Changelog Description

Missing writeUVs on the Alembic extraction.

Testing notes:

  1. Remove any overrides on project_settings/maya/publish/ExtractAlembic
  2. Publish pointcache or animation.
  3. Validate published geometry has UVs.

@tokejepsen tokejepsen requested a review from moonyuet May 10, 2024 09:10
@tokejepsen tokejepsen added the type: bug Something isn't working label May 10, 2024
@ynbot ynbot added host: Maya size/XS Denotes a PR changes 0-99 lines, ignoring general files labels May 10, 2024
@moonyuet
Copy link
Member

moonyuet commented May 10, 2024

I slightly look at the code and I compared with the schema_maya_publish.json and it doesn't have the WriteUVs flag (they have WriteUVSets flag instead). Are we gonna add or change the name of that specific flag in schema_maya_publish.json?
image
I am asking this as WriteUVs doesn't show up in my setting
image

@BigRoy
Copy link
Collaborator

BigRoy commented May 10, 2024

I slightly look at the code and I compared with the schema_maya_publish.json and it doesn't have the WriteUVs flag (they have WriteUVSets flag instead). Are we gonna add or change the name of that specific flag in schema_maya_publish.json?

Note that I believe writeUVSets and writeUVs is a different flag on the alembic exporter. The first meaning "export multiple UV sets" - the other meaning 'write any UV set'. If only the latter is enabled then only the current UV set would be exported.

See both present here:

Not entirely sure, but I believe that is the case.

Correction

NEVERMIND - That's uvWrite it seems.

See:

It seems the other flag is uvWrite on the Alembic side of things.

@moonyuet
Copy link
Member

I slightly look at the code and I compared with the schema_maya_publish.json and it doesn't have the WriteUVs flag (they have WriteUVSets flag instead). Are we gonna add or change the name of that specific flag in schema_maya_publish.json? image I am asking this as WriteUVs doesn't show up in my setting image

Note that I believe writeUVSets and writeUVs is a different flag on the alembic exporter. The first meaning "export multiple UV sets" - the other meaning 'write any UV set'. If only the latter is enabled then only the current UV set would be exported.

See both present here:

Not entirely sure, but I believe that is the case.

We need to add WriteUVs into the schema_maya_publish.json then, if both WriteUVs and WriteUVSets existed as job arguments.

@BigRoy
Copy link
Collaborator

BigRoy commented May 10, 2024

We need to add WriteUVs into the schema_maya_publish.json then, if both WriteUVs and WriteUVSets existed as job arguments.

Thanks - I edited my previous comment seems I misremembered slightly. We need both uvWrite and writeUVSets. And indeed writeUVs seems to be invalid/typo.

So I suppose:

  • writeUVs -> writeUVSets
  • Also enable uvWrite.

Copy link
Member

@moonyuet moonyuet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested successfully in Maya
image

@BigRoy
Copy link
Collaborator

BigRoy commented May 10, 2024

Tested successfully in Maya image

Would be good - that aside of the publish passing you also confirm in the test that the resulting publish contains UVs.

@moonyuet
Copy link
Member

Tested successfully in Maya image

Would be good - that aside of the publish passing you also confirm in the test that the resulting publish contains UVs.

yes it has the UVs.
image

Copy link
Collaborator

@BigRoy BigRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tokejepsen tokejepsen assigned antirotor and unassigned moonyuet May 10, 2024
@jakubjezek001 jakubjezek001 changed the title Maya: Correct Alembic export defaults Maya: Correct Alembic export defaults AY-5273 May 20, 2024
@ynbot
Copy link
Contributor

ynbot commented May 20, 2024

Task linked: AY-5273 OP: Alembic UVs write issue

@m-u-r-p-h-y m-u-r-p-h-y assigned LiborBatek and unassigned LiborBatek May 24, 2024
@antirotor antirotor merged commit 657b0a4 into develop Jun 12, 2024
1 check passed
@ynbot ynbot added this to the next-patch milestone Jun 12, 2024
@tokejepsen tokejepsen deleted the tokejepsen-patch-2 branch June 14, 2024 07:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
host: Maya size/XS Denotes a PR changes 0-99 lines, ignoring general files type: bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants