This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
Bugfix/ Houdini: fix default redshift version #6192
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ynbot
added
size/XS
MustafaJafar
changed the title
BigRoy
approved these changes
Feb 2, 2024
There was a problem hiding this comment.
Didn't test it - but this looks like the simplest fix.
It might be good to add a comment above this line explaining why we pick "1" as default value, e.g. explaining that's the default version the Deadline Redshift plug-in falls back to when Plug-in info "Version" is not specified.
BigRoy
approved these changes
Feb 2, 2024
openpype/modules/deadline/plugins/publish/submit_houdini_render_deadline.py
Outdated
Show resolved
Hide resolved
openpype/modules/deadline/plugins/publish/submit_houdini_render_deadline.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Roy Nieterau <[email protected]>
Co-authored-by: Roy Nieterau <[email protected]>
|
Because we're splitting OpenPype into ayon-core and individual host addons, this PR would have to be re-created to target one of those. We're closing it down, but we'll he happy for a new PR to ynput/ayon-core or the host addon repository once it's up. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
Fixing the bug reported here https://community.ynput.io/t/houdini-redshift-deadline-executable-error/1210
Let me quote BigRoy's comment:
If we specify Version as
""then indeed it tries to access the version asRedshift_Executable_instead of the Deadline defaultRedshift_Executable_1Testing notes:
REDSHIFT_VERSIONenv doesn't exist