-
Notifications
You must be signed in to change notification settings - Fork 128
Loader: Add colorspace entry to Version Info #5459
Conversation
I've tested it in Houdini and Maya, and this PR doesn't seem to affect them. |
# Add colorspace info to Version Info tab | ||
version_colorspace = version_doc["data"].get("colorspace") | ||
colorspace_html = "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't the colorspace on the representations instead of the version?
@jakubjezek001 do you know how it should be? Because representations can have differing colorspaces, yes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked a few entries in MongoDB and I can only see it on the version data
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In fact @BigRoy is right @fabiaserra. The new colorspaceData distribution is kept on representation level. The version data colorspace key is still available but will be removed soon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah fair enough, no big deal, it was just a fast utility for me while testing the OpenRV integration to make sure what I was loading was getting the expected colorspace, happy to close it
It should affect them, but only for publishes that have colorspace data written into them. If you're not seeing the information right hand side even if the colorspace data exists on the version/representations than I'd say it's a bug. |
Exactly |
I am not sure how to put my mind into this. I appreciate your attempt @fabiaserra but I am afraid this will only work for couple months only. I am suggesting to close it. But nothing will be broken if we merge it ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Changelog Description
Small addition to add "Colorspace" entry in Version Info tab in loader if version has colorspace data
Testing notes: