Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Loader: Add colorspace entry to Version Info #5459

Closed

Conversation

fabiaserra
Copy link
Contributor

Changelog Description

Small addition to add "Colorspace" entry in Version Info tab in loader if version has colorspace data

image

Testing notes:

  1. Open the loader and click on a Version entry that has colorspace data

@ynbot ynbot added type: feature Larger, user affecting changes and completely new things size/XS Denotes a PR changes 0-99 lines, ignoring general files labels Aug 16, 2023
@MustafaJafar
Copy link
Contributor

I've tested it in Houdini and Maya, and this PR doesn't seem to affect them.

Comment on lines +744 to +746
# Add colorspace info to Version Info tab
version_colorspace = version_doc["data"].get("colorspace")
colorspace_html = ""
Copy link
Collaborator

@BigRoy BigRoy Aug 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't the colorspace on the representations instead of the version?
@jakubjezek001 do you know how it should be? Because representations can have differing colorspaces, yes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked a few entries in MongoDB and I can only see it on the version data

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In fact @BigRoy is right @fabiaserra. The new colorspaceData distribution is kept on representation level. The version data colorspace key is still available but will be removed soon.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah fair enough, no big deal, it was just a fast utility for me while testing the OpenRV integration to make sure what I was loading was getting the expected colorspace, happy to close it

@BigRoy
Copy link
Collaborator

BigRoy commented Aug 17, 2023

I've tested it in Houdini and Maya, and this PR doesn't seem to affect them.

It should affect them, but only for publishes that have colorspace data written into them. If you're not seeing the information right hand side even if the colorspace data exists on the version/representations than I'd say it's a bug.

@fabiaserra
Copy link
Contributor Author

I've tested it in Houdini and Maya, and this PR doesn't seem to affect them.

It should affect them, but only for publishes that have colorspace data written into them. If you're not seeing the information right hand side even if the colorspace data exists on the version/representations than I'd say it's a bug.

Exactly

@jakubjezek001
Copy link
Member

I am not sure how to put my mind into this. I appreciate your attempt @fabiaserra but I am afraid this will only work for couple months only. I am suggesting to close it. But nothing will be broken if we merge it ;)

Copy link
Member

@jakubjezek001 jakubjezek001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
community contribution size/XS Denotes a PR changes 0-99 lines, ignoring general files type: feature Larger, user affecting changes and completely new things
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants