Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Maya + Blender: Pyblish plugins removed unused version and category attributes #4402

Merged
merged 4 commits into from
Feb 1, 2023

Conversation

BigRoy
Copy link
Collaborator

@BigRoy BigRoy commented Jan 31, 2023

Brief description

Once upon a time in a land far far away there lived a few plug-ins who felt like they didn't belong in generic boxes and felt they needed to be versioned well above others. They tried, but with no success.

Description

Even though they now lived in a universe with elaborate version and category attributes embedded into their tiny little plug-in DNA this particular deviation has been greatly unused. There is nothing special about the version, nothing special about the category.

It does nothing.

Additional info

Having these attributes on these plug-ins just meant other developers would join in thinking "hell yeah baby!" producing their own special plug-in babies with category and version attributes of their own. Well, they were fooled.

Their time spent on adding these precious attributes meant more lines of code that ended up doing nothing - except clutter and increase memory usage of machines across the world!

It's time to say, no more! This is where it stops.

Unless someone has a good use for these.

Testing notes:

  1. Test blender + maya publishing with these plug-ins, but they should remain unaffected.

@iLLiCiTiT
Copy link
Member

Since maya plugins were last modified 4 years ago and I expect blender just copied the plugins and modified the content, it can be safely removed.

BTW I don't know what category was meant for?

@iLLiCiTiT iLLiCiTiT added the type: enhancement Enhancements to existing functionality label Feb 1, 2023
@BigRoy
Copy link
Collaborator Author

BigRoy commented Feb 1, 2023

BTW I don't know what category was meant for?

I guess the intent was to group plugins so the end user would see "these are for UVS, these are for meshes, these are for transforms" basically some sort of grouping to a category ai suppose. I believe it originated from our Colorbleed code originally - it was just always unused.

@iLLiCiTiT iLLiCiTiT merged commit ece8176 into ynput:develop Feb 1, 2023
@github-actions github-actions bot added this to the next-patch milestone Feb 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: enhancement Enhancements to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants