This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
Houdini: New publisher code tweak #4374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antirotor
approved these changes
Jan 27, 2023
antirotor
added
host: Houdini
type: enhancement
BigRoy
commented
Jan 27, 2023
| creator_id = i.parm("creator_identifier").eval() | ||
| if creator_id not in shared_data["houdini_cached_subsets"]: | ||
| shared_data["houdini_cached_subsets"][creator_id] = [i] | ||
| if shared_data.get("houdini_cached_subsets") is not None: |
There was a problem hiding this comment.
@antirotor Sorry, sorry, sorry, sorry! There was a TYPO in this PR!!!
This should have been is None:
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief description
This is cosmetics only - the previous code to me felt quite unreadable due to the lengthy strings being used.
Description
Code should do roughly the same, but just be reformatted.
Testing notes: