-
Notifications
You must be signed in to change notification settings - Fork 129
General: missing comment on standalone and tray publisher #4303
General: missing comment on standalone and tray publisher #4303
Conversation
Check for context must be preserved until old Pyblish is completely eradicated as comment could be filled after collection phase, therefore not caught by collector.
Printing what is actually missing is more helpful than only full data.
@@ -45,7 +45,8 @@ def process(self, instance): | |||
host_name = context.data["hostName"] | |||
app_name = context.data["appName"] | |||
app_label = context.data["appLabel"] | |||
comment = instance.data["comment"] | |||
# context comment is fallback until old Pyblish is removed | |||
comment = instance.data["comment"] or context.data.get("comment") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is duplicate of what happens here https://github.com/ynput/OpenPype/blob/develop/openpype/plugins/publish/collect_comment.py#L99
The "comment"
should be always filled. Maybe only if instance is created after the collector?
Pyblish allows modifying comment after collect phase, eg. collector wouldn't collect it. Should be pushed back to Collect phase after Pyblish is eradicated.
Availability of comment on instance has been resolved by bumping up order of CollectComment.
Pushed collector to Extract phase because of Pyblish. Marked with TODO, should be refactored when Pyblish is gone. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is just a slight inconsistency in terminology. There are three terms used and it may be a bit confusing. We are writing a |
Brief description
Comment might have not been collected when inserted only after collection phase which resulted in not sending comment to Ftrack.
Additional info
Clean-up of comment and using only comments on instances is good step, but as far as we are still using old Pyblish, context comment should be kept as a fallback (comment might be filled after collection phase, in this case it is present only on context level. Eg. artists knows/sees that it is filled, but integrator prints it is not there. Another approach would be to disable comments field after publish is started, but I didn't want to mess with Pyblish.)
Comment field in Publisher is controlled by
project_settings/global/publish/collect_comment_per_instance
. To show comment field this should be set:Testing notes:
Integrate Ftrack note
and Ftrack for presence of commentintent
andcomment
, skippingintent
is quite easy in SP, in Publisher field for it is missing completely, imho)