Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

SiteSync: sftp connection failing when shouldnt be tested #4278

Merged
merged 3 commits into from
Jan 4, 2023
Merged

SiteSync: sftp connection failing when shouldnt be tested #4278

merged 3 commits into from
Jan 4, 2023
+19 −52

Conversation

kalisp
Copy link
Member

@kalisp kalisp commented Jan 4, 2023

Brief description

Fix check if site is active, eg. correctly configured to be used, only for active and remote site actually set on a project.
Previously it went through all configured sites, even if they weren't used.

Description

Additional info

Site might be configured as possible target, but artist might not use it. They are in studio and not using SiteSync at all etc.

Closes #4125

Testing notes:

  • Enable Site Sync module, create a SFTP(or Gdrive without any values filled) site with wrong credentials and enable it for your production.
  • Change your local settings to local and studio (not to the sftp site).
  • Restart Tray, and look to the logs, it tries to connect when it shouldn't because the user settings don't ask for it.

@kalisp
OP-4490 - safer resolving if site is active
e44f585
@kalisp
OP-4490 - fixed unnecessary checks
8527554 
Configured sites were checked all the time even if they weren't used.
Now it checks only sites that are set for project.
@kalisp kalisp added the type: bug Something isn't working label Jan 4, 2023
@kalisp kalisp self-assigned this Jan 4, 2023
m-u-r-p-h-y
m-u-r-p-h-y approved these changes Jan 4, 2023
View reviewed changes
Copy link
Member

@m-u-r-p-h-y m-u-r-p-h-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with SiteSync enabled and sftp server defined it is not giving me the error anymore

seems to work fine

@kalisp kalisp merged commit afdba99 into develop Jan 4, 2023
@kalisp kalisp deleted the bugfix/OP-4490_SFTP-connection-failing-when-shouldnt-be-tested branch January 4, 2023 18:11
@github-actions github-actions bot added this to the next-patch milestone Jan 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@m-u-r-p-h-y m-u-r-p-h-y m-u-r-p-h-y approved these changes

@Tilix4 Tilix4 Awaiting requested review from Tilix4

@64qam 64qam Awaiting requested review from 64qam

Assignees

@kalisp kalisp

Labels
type: bug Something isn't working
Projects
None yet
Milestone
3.14.10
Development

Successfully merging this pull request may close these issues.

SFTP connection failing when shouldn't be tested
2 participants
@kalisp @m-u-r-p-h-y