This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
AfterEffects: publish multiple compositions #4092
Merged
+263
−151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There cannot be multiple Render items for same composition in Render Queue. There cannot be multiple output modules for same Render item.
Do not do get render queue again, should be already collected.
Weird synchronization issue was happening in getRenderInfo when re-publishing published workfile. This implementation is ugly, but seems to work.
kalisp
added
type: enhancement
|
Task linked: OP-4361 After Effects multiple compositions |
64qam
approved these changes
Nov 14, 2022
|
After discussion it will be required to have multiple output modules per composition. |
There is new flag to allow use composition name Updated subset template. Removed obsolete 'renderLocal', now it is only 'render' with a flag.
Previously it was renaming composition with subset name, this was missing in new creator. Renamed items to more descriptive 'comps'.
Working version for local rendering.
|
Updated, there could be multiple output modules per composition (eg. output formats). Each of them is added as a representation. |
64qam
approved these changes
Nov 15, 2022
iLLiCiTiT
reviewed
Nov 15, 2022
iLLiCiTiT
reviewed
Nov 15, 2022
iLLiCiTiT
approved these changes
Nov 15, 2022
kalisp
deleted the
feature/OP-4361_After-Effects-multiple-compositions
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief description
This allows publishing of multiple compositions in one publish process.
Description
Previously there was limitation on single composition, most probably because of Deadline, but that seems to be resolved.
Now multiple composition could be published.
There are still some assertions:
Release Info:
Added new flag to AE Creator:
Updated default subset template in
project_settings/global/tools/creator/subset_name_profiles. If you have there any overrides, you must add this for AE:Additional info
~~
There is still outstanding question about naming convention for created subsets. As previously there was only single composition, using composition name in subset name didn't make any sense. Now multiple subsets need to be differentiated.
Currently only option is to manually modify
Variant(eg. instead ofMainbut thereComposition1Mainfor example).This limits a position of composition name in subset name. I could implement adding composition name to the subset similarly as in PS, where
{layer}placeholder is possible (when multiple subsets are created).I have two issues there:
layervscompositionvsrenderLayervs...). But that is probably bigger discussion for different day{composition}should be probably used only when there are multiple subsets created. (In other case there will be difference between 'old' (without) and 'new' (with) subsets. Solution could be have explicit toggleUse composition name in subsettoggle (default to False) on Creator.~~
Note: This is built on top of
release/3.15.xbranch, eg. Python 3.9 and Publisher only.Testing notes:
Variantto differentiate them