Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Nuke: validate that instances are in the correct cotext, and fix #401

Conversation

tokejepsen
Copy link
Member

Moved the equivalent Maya plugin into global and merged with Nuke.
Fixed Nuke instances collection not using node data for asset.

Moved the equivalent Maya plugin into global and merged with Nuke.
Fixed Nuke instances collection not using node data for asset.
@tokejepsen tokejepsen added type: enhancement Enhancements to existing functionality host: Nuke host: Maya labels Jul 29, 2020
@tokejepsen tokejepsen self-assigned this Jul 29, 2020
Copy link
Member

@antirotor antirotor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At first it felt odd to see host specific imports in global plugin but then as hard as I thought about it I couldn't find anything wrong. This way it is easy to re-use this code for other hosts in future.

@antirotor
Copy link
Member

Resolves #390
Closes #399

@mkolar
Copy link
Member

mkolar commented Aug 3, 2020

yeah I agree, this will be much easier to maintain, than completely separate plugins.

@mkolar mkolar added this to the 2.12 milestone Aug 3, 2020
@mkolar mkolar merged commit ea568ea into ynput:2.x/develop Aug 3, 2020
@mkolar mkolar changed the title Instance in Same Context for Nuke Nuke: validate that instances are in the correct cotext, and fix Aug 3, 2020
@tokejepsen tokejepsen deleted the 2.x/feature/nuke_instance_in_same_context branch August 3, 2020 11:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
host: Maya host: Nuke type: enhancement Enhancements to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants