This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 129
Webpublisher: Webpublisher is used as addon #3740
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Task linked: OP-3793 Webpublisher as addon |
iLLiCiTiT
added
the
type: refactor
Structural changes not affecting functionality
label
Aug 25, 2022
64qam
suggested changes
Aug 26, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When using "farm processing" it fails for PS:
Traceback (most recent call last):
File "start.py", line 1151, in boot
File "c:\Users\pypeclub\code\OpenPype\build\exe.win-amd64-3.7\dependencies\click\core.py", line 829, in __call__
return self.main(*args, **kwargs)
File "c:\Users\pypeclub\code\OpenPype\build\exe.win-amd64-3.7\dependencies\click\core.py", line 782, in main
rv = self.invoke(ctx)
File "c:\Users\pypeclub\code\OpenPype\build\exe.win-amd64-3.7\dependencies\click\core.py", line 1259, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
File "c:\Users\pypeclub\code\OpenPype\build\exe.win-amd64-3.7\dependencies\click\core.py", line 1259, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
File "c:\Users\pypeclub\code\OpenPype\build\exe.win-amd64-3.7\dependencies\click\core.py", line 1259, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
File "c:\Users\pypeclub\code\OpenPype\build\exe.win-amd64-3.7\dependencies\click\core.py", line 1066, in invoke
return ctx.invoke(self.callback, **ctx.params)
File "c:\Users\pypeclub\code\OpenPype\build\exe.win-amd64-3.7\dependencies\click\core.py", line 610, in invoke
return callback(*args, **kwargs)
TypeError: publishfromapp() got an unexpected keyword argument 'host'```
Please try again. |
64qam
approved these changes
Aug 26, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief description
Webpublished is defined as addon which gave him ability to have own cli functionality.
Description
Implementer
WebpublisherAddon
, it's main purpose is to give ability to define cli commands. Cli commands from global commands were "duplicated" into addon:remotepublish
->module webpublisher publish
remotepublishfromapp
->module webpublisher publishfromapp
webpublisherwebserver
->module webpublisher webserver
All of them should do the same job so they're backwards compatible. Webservice commands were modified to follow new arguments.
Moved webpublisher specific lib function from
openpype.lib
into webpublisher itself. The original "remote publish" function was moved intoopenpype.pipeline.publish.lib
and renamed toremote_publish
.Webpublisher has implemented Host class
WebpublisherHost
to be installed.Testing notes:
openpype module webpublisher webserver
and legacyopenpype webpublisherwebserver