This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 129
General: Fix finding of last version #3656
Merged
+157
−138
Merged
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
312b6d3
:bug: fix finding of last version
antirotor 0c72b8e
:recycle: refactor compatibility check
antirotor c1d3d70
:rotating_light: fix hound :dog:
antirotor 7176723
:bug: fix arguments and recursive folders
antirotor 60ea972
:rotating_light: fix hound :dog:
antirotor 8b94d74
show outdated build dialog when expected version can't be used with c…
iLLiCiTiT ad64c3a
added backwards compatibility for 'is_compatible' method
iLLiCiTiT 1ad9728
:recycle: remove forgotten args, fix typos
antirotor b61e47a
:recycle: don't look for compatible version automatically
antirotor aa0fe93
:bug: fix version list
antirotor c638383
:recycle: remove unnecessary type hint
antirotor cfb14d3
Show dialog if installed version is not compatible in UI mode
iLLiCiTiT File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
# -*- coding: utf-8 -*- | ||
"""Package declaring Pype version.""" | ||
"""Package declaring OpenPype version.""" | ||
__version__ = "3.13.1-nightly.1" |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't the
item.name
match exactly withf"{installed_version.major}.{installed_version.minor}"
?So wouldn't this just be
if item.name == f"{installed_version.major}.{installed_version.minor}"
or alike?Should be faster too, and more readable. Less string splitting and just a single comparison.
major_minor
could even be defined outside of theiterdir()
loop.I also expected this should be
openpype_versions.extend()
instead of append when looking at the code?And shouldn't we also "continue" if we've already identified it as a major minor subfolder, so add
continue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is actually wrong as it shouldn't compare those at all and dive deeper if it matches regex
^\d+\.\d+$