Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Nuke: Add aov matching even for remainder and prerender #3060

Conversation

kalisp
Copy link
Member

@kalisp kalisp commented Apr 13, 2022

Brief description

Previously filtering used only for collections and 'render' family.

Description

This should allow more control when to add 'review' tag to representation.

Testing notes:

  1. Create prerender write node in Nuke
  2. configure project_settings/deadline/publish/ProcessSubmittedJobOnFarm/aov_filter
    2a. configure that pattern matches created subset name
    2b. configure that pattern doesn't match created subset name
  3. publish
  4. check Ftrack

Previously filtering used only for collections.
@kalisp kalisp added the type: bug Something isn't working label Apr 13, 2022
@kalisp kalisp requested a review from 64qam April 13, 2022 15:37
@kalisp kalisp self-assigned this Apr 13, 2022
@ynbot
Copy link
Contributor

ynbot commented Apr 13, 2022

@BigRoy
Copy link
Collaborator

BigRoy commented Apr 13, 2022

I'd actually recommend doing clique.assemble with an explicit frames pattern and minimum_items=1. It'd allow less types of naming conventions to pass for collections but I feel like they'd still match all that we wanted to support with OpenPype. The new integrator is actually already using a refactored way of clique.assemble. It's more explicit and avoids errors. It however does only allow filenames rendered as filename_whatever.{frame}.{ext} to be assembled as a collection and won't allow e.g. filename_v{frame}.{ext} or filename{frame}.{ext}.

Without this rendering a single frame (that still has a frame number) would currently not be assembled as a sequence which seems like an inconsistency. We should only be seeing remainders if there was no frame number in the files at all - not also see it if there's just a single frame. No?

@kalisp kalisp merged commit b9111bd into develop Apr 15, 2022
@kalisp kalisp deleted the bugfix/OP-2958_Nuke-preRender-publish-via-farm-to-not-submit-to-ftrack branch April 15, 2022 07:25
@kalisp
Copy link
Member Author

kalisp commented Apr 15, 2022

Lets test it with minimum_items=1 in next PR, this one seems to be working and it is needed to get release out.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants