Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Deadline: Move module one hierarchy level higher #2789

Merged
merged 3 commits into from
Feb 23, 2022

Conversation

iLLiCiTiT
Copy link
Member

@iLLiCiTiT iLLiCiTiT commented Feb 22, 2022

Brief changes

Moved deadline module from default_modules folder next to base modules.

Changes

  • moved the deadline folder to openpype/modules/deadline
  • moved deadline repository files from openpype/vendor/deadline to openpype/modules/deadline/repository.
  • openpype/lib/abstract_submit_deadline.py moved to openpype/modules/deadline/abstract_submit_deadline.py

Notes

Affecting PRs

Testing notes:

  1. Deadline should work as before

@iLLiCiTiT iLLiCiTiT self-assigned this Feb 22, 2022
@iLLiCiTiT iLLiCiTiT added the module: Deadline AWS Deadline related features label Feb 22, 2022
@BigRoy
Copy link
Collaborator

BigRoy commented Feb 22, 2022

Affecting PRs

This is not an affected PR but an issue: https://github.com/pypeclub/OpenPype/issues/2787
But this one is an affected PR: #2625

@BigRoy
Copy link
Collaborator

BigRoy commented Feb 22, 2022

With Deadline being its own module should we maybe also move along vendor/deadline/custom/plugins to be closer to the module itself? (Note that then we'd also need to update the documentation)

Just so that we can get to a point where all Deadline logic at some point can be encapsulated within the module?

@iLLiCiTiT
Copy link
Member Author

With Deadline being its own module should we maybe also move along vendor/deadline/custom/plugins to be closer to the module itself?

I agree. Is the plugin installed using code or it must be copied manually so it is possible just move it and change documentation?

@BigRoy
Copy link
Collaborator

BigRoy commented Feb 22, 2022

or it must be copied manually so it is possible just move it and change documentation?

Those files must currently be copied manually. See the Admin Docs for Deadline Module.

@BigRoy
Copy link
Collaborator

BigRoy commented Feb 22, 2022

Didn't notice this before, but should we also move openpype/lib/abstract_submit_deadline.py?

Copy link
Member

@kalisp kalisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work.

@iLLiCiTiT iLLiCiTiT merged commit e8b7e64 into develop Feb 23, 2022
@iLLiCiTiT iLLiCiTiT deleted the feature/move_deadline_module branch February 23, 2022 12:50
@mkolar mkolar added the type: refactor Structural changes not affecting functionality label Mar 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
module: Deadline AWS Deadline related features type: refactor Structural changes not affecting functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants