This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
Slack: Add review to notification message #2498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kalisp
added
type: enhancement
|
Task linked: OP-2204 Feature - Slack: URL to reviewable |
iLLiCiTiT
reviewed
Jan 7, 2022
|
Isn't that "review filepath" rather then link? |
iLLiCiTiT
reviewed
Jan 7, 2022
website/docs/module_slack.md
Outdated
| @@ -69,8 +81,22 @@ Few keys also have Capitalized and UPPERCASE format. Values will be modified acc | |||
| **Available keys:** | |||
There was a problem hiding this comment.
I would rather point to anatomy data and here add those keys that are not in anatomy data. It is hell to track all docs where these keys are when something in anatomy changes.
Co-authored-by: Jakub Trllo <[email protected]>
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| task_data = fill_data.get("task") | ||
| for key, value in task_data.items(): | ||
| fill_key = "task[{}]".format(key) | ||
| fill_pairs.append((fill_key , value)) |
…P-2204_Feature---Slack-URL-to-reviewable
…URL-to-reviewable' into feature/OP-2204_Feature---Slack-URL-to-reviewable
64qam
approved these changes
Jan 13, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief description
Currently only thumbnail is present, it was required to add link to review.
Description
There are two options now how to add review to Slack notification message.
Additional info
Uploading of review must be though through as in case of large sizes of reviews publish might be too slow and one will be hitting on Slack limits pretty soon.
Contained in #2499, use #2499 to test both.
Testing notes:
renderfamilytest_integrationchannel