This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
Photoshop: mark publishable instances #1093
Merged
+220
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implemented list_instances and remove_instance methods
Warn if duplicate subsets found
Updates subset name in instance metadata and layer name
Use layer name and PUBLISH_ICON, not subset name
Changed structure of metadata from {} to []
Added rename_layer method
Switched to attr instead of namedtuple (same as in AE)
PS in Windows opens path with / wrong. File cannot be saved as its name is full path
AE in Windows opens path with / wrong. File cannot be saved as its name is full path
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| temp_layers_meta = {} | ||
| for layer_meta in layers_data: | ||
| layer_id = layer_meta.get("uuid") or \ | ||
| (layer_meta.get("members")[0]) |
There was a problem hiding this comment.
continuation line over-indented for hanging indent
| if group.long_name: | ||
| for directory in group.long_name[::-1]: | ||
| name = directory.replace(stub.PUBLISH_ICON, '').\ | ||
| replace(stub.LOADED_ICON, '') |
There was a problem hiding this comment.
continuation line over-indented for hanging indent
| "Instance subset names are not unique. " + | ||
| "Remove duplicates via SubsetManager." | ||
| ) | ||
| assert len(subset_names) == len(set(subset_names)), msg |
mkolar
approved these changes
Mar 10, 2021
mkolar
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #643
Added icons:
℗ - highlight publishable instance
▼ - highlight loaded container
Added SubsetManager and implemented methods
Switched representation from namedtuple to attr as former was immutable
Added rename_layer method
Fixed small bugs
Fixed loading of last workfile in PS AND AE
Requires:
ynput/avalon-core#294