Add custom model chunk upload #1
Conversation
|
Add some test and make sure |
| Objects.requireNonNull(name); | ||
| Objects.requireNonNull(version); | ||
| Objects.requireNonNull(url); | ||
| Objects.requireNonNull(chunkNumber); |
There was a problem hiding this comment.
Check if totalChunks is null or not?
|
|
||
| private String name; | ||
| private Integer version; | ||
| private byte[] url; |
There was a problem hiding this comment.
Seems url is not a good name, rename to content ?
| MLUploadChunkInput mlUploadChunkInput = uploadModelRequest.getMlUploadInput(); | ||
|
|
||
| try (ThreadContext.StoredContext context = client.threadPool().getThreadContext().stashContext()) { | ||
| MLTask mlTask = MLTask.builder() |
There was a problem hiding this comment.
Seems mlTask not being used here. Remove it?
| @VisibleForTesting | ||
| MLUploadModelChunkRequest getRequest(RestRequest request) throws IOException { | ||
| String name = request.param("name"); | ||
| // System.out.println(name); |
| String chunk_number = request.param("chunk_number"); | ||
| // System.out.println(chunk_number); | ||
| String total_chunks = request.param("total_chunks"); | ||
| byte[] content = request.content().streamInput().readAllBytes(); |
There was a problem hiding this comment.
This is risky if user upload a big chunk. Suggest checking the chunk size first.
|
I see there are 17 commits in total now and there are 9 more commits after first round of review. That's not easy for code reviewer to review the new updates. Suggest keep the commit history clean, at least squash the small commits into one, or squash the latest 9 commits into one, so reviewer can only check the updates of one commit quickly. |
This commit adds the following: Unit and integration tests for ML custom model chunk upload Reformatted some code for better readability Signed-off-by: Thomas Ma [email protected]
…pensearch-2.2 merging to squish last 9 commits
Description
This pull request adds a new API call for uploading a chunk of a custom model to OpenSearch.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.