Fix type mismatch (opensearch-project#2990)

Signed-off-by: Louis Chu <[email protected]>
ykmr1224 · Sep 5, 2024 · 06c56e7 · 06c56e7
1 parent da622eb
commit 06c56e7
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/...ain/java/org/opensearch/sql/spark/config/OpenSearchAsyncQuerySchedulerConfigComposer.java b/...ain/java/org/opensearch/sql/spark/config/OpenSearchAsyncQuerySchedulerConfigComposer.java
@@ -24,12 +24,12 @@ public void compose(
       SparkSubmitParameters sparkSubmitParameters,
       DispatchQueryRequest dispatchQueryRequest,
       AsyncQueryRequestContext context) {
-    String externalSchedulerEnabled =
+    Boolean externalSchedulerEnabled =
         settings.getSettingValue(Settings.Key.ASYNC_QUERY_EXTERNAL_SCHEDULER_ENABLED);
     String externalSchedulerInterval =
         settings.getSettingValue(Settings.Key.ASYNC_QUERY_EXTERNAL_SCHEDULER_INTERVAL);
     sparkSubmitParameters.setConfigItem(
-        FLINT_JOB_EXTERNAL_SCHEDULER_ENABLED, externalSchedulerEnabled);
+        FLINT_JOB_EXTERNAL_SCHEDULER_ENABLED, String.valueOf(externalSchedulerEnabled));
     sparkSubmitParameters.setConfigItem(
         FLINT_JOB_EXTERNAL_SCHEDULER_INTERVAL, externalSchedulerInterval);
   }

diff --git a/...java/org/opensearch/sql/spark/config/OpenSearchAsyncQuerySchedulerConfigComposerTest.java b/...java/org/opensearch/sql/spark/config/OpenSearchAsyncQuerySchedulerConfigComposerTest.java
@@ -31,7 +31,7 @@ public void setUp() {
   @Test
   public void testCompose() {
     when(settings.getSettingValue(Settings.Key.ASYNC_QUERY_EXTERNAL_SCHEDULER_ENABLED))
-        .thenReturn("true");
+        .thenReturn(true);
     when(settings.getSettingValue(Settings.Key.ASYNC_QUERY_EXTERNAL_SCHEDULER_INTERVAL))
         .thenReturn("10 minutes");
 
@@ -46,7 +46,7 @@ public void testCompose() {
   @Test
   public void testComposeWithDisabledScheduler() {
     when(settings.getSettingValue(Settings.Key.ASYNC_QUERY_EXTERNAL_SCHEDULER_ENABLED))
-        .thenReturn("false");
+        .thenReturn(false);
 
     composer.compose(sparkSubmitParameters, dispatchQueryRequest, context);
 
@@ -57,7 +57,7 @@ public void testComposeWithDisabledScheduler() {
   @Test
   public void testComposeWithMissingInterval() {
     when(settings.getSettingValue(Settings.Key.ASYNC_QUERY_EXTERNAL_SCHEDULER_ENABLED))
-        .thenReturn("true");
+        .thenReturn(true);
     when(settings.getSettingValue(Settings.Key.ASYNC_QUERY_EXTERNAL_SCHEDULER_INTERVAL))
         .thenReturn("");