Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yksmp could use abstraction #1426

Open
vext01 opened this issue Oct 21, 2024 · 1 comment
Open

yksmp could use abstraction #1426

vext01 opened this issue Oct 21, 2024 · 1 comment
Assignees

Comments

@vext01
Copy link
Contributor

vext01 commented Oct 21, 2024

There are lots of places in our codebase where raw DWARF register numbers are used. That might have been OK if we had only one numbering scheme, but since we use dynasm and that has a different numbering scheme, it might be worth doing some abstraction to give the numbers symbolic names.

Examples of places that would need attention:

(please add more as you encounter them)

@ltratt
Copy link
Contributor

ltratt commented Oct 21, 2024

s/might be worth doing/absolutely 100% definitely unconditionally without-a-shadow-of-a-doubt must do/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants