Skip to content

Commit

Permalink
Address review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
mridulm committed Mar 18, 2014
1 parent 9bda70e commit 167fad8
Showing 1 changed file with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,8 @@ private[spark] class TaskSetManager(
* this temporarily prevents a task from re-launching on an executor where
* it just failed.
*/
private[this] val EXECUTOR_TASK_BLACKLIST_TIMEOUT =
conf.getLong("spark.task.executorBlacklistTimeout", 0L)
private val EXECUTOR_TASK_BLACKLIST_TIMEOUT =
conf.getLong("spark.scheduler.executorTaskBlacklistTime", 0L)

// Quantile of tasks at which to start speculation
val SPECULATION_QUANTILE = conf.getDouble("spark.speculation.quantile", 0.75)
Expand All @@ -82,7 +82,7 @@ private[spark] class TaskSetManager(
val successful = new Array[Boolean](numTasks)
private val numFailures = new Array[Int](numTasks)
// key is taskId, value is a Map of executor id to when it failed
private[this] val failedExecutors = new HashMap[Int, HashMap[String, Long]]()
private val failedExecutors = new HashMap[Int, HashMap[String, Long]]()
val taskAttempts = Array.fill[List[TaskInfo]](numTasks)(Nil)
var tasksSuccessful = 0

Expand Down Expand Up @@ -265,7 +265,7 @@ private[spark] class TaskSetManager(
* Is this re-execution of a failed task on an executor it already failed in before
* EXECUTOR_TASK_BLACKLIST_TIMEOUT has elapsed ?
*/
private[this] def executorIsBlacklisted(execId: String, taskId: Int): Boolean = {
private def executorIsBlacklisted(execId: String, taskId: Int): Boolean = {
if (failedExecutors.contains(taskId)) {
val failed = failedExecutors.get(taskId).get

Expand Down

0 comments on commit 167fad8

Please sign in to comment.