Add auto commenting to PR with the preview url. #4
Conversation
Also, removed 10 character branch name limit Update README.md Add comment curl Pass comment url to the action Gate for toen Update README.md Update action.yml Update README.md Update entrypoint.sh Update action.yml Update entrypoint.sh Update README.md Update Dockerfile Update entrypoint.sh Update README.md Update entrypoint.sh
Merge Upstream
| BRANCH_NAME=$1 | ||
| AMPLIFY_COMMAND=$2 | ||
| COMMENT_URL=$3 |
There was a problem hiding this comment.
a small readability improvement.
There was a problem hiding this comment.
Hi @daltonfury42 I like this function! Thanks for the PR. Please see the comment and do you mind removing | cut -c-10 from the examples.md too? Thanks!
README.md
Outdated
| @@ -58,6 +59,7 @@ The following settings must be passed as environment variables as shown in the e | |||
| | `AWS_REGION` | The region where you created your bucket. Set to `us-east-1` by default. [Full list of regions here.](https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/using-regions-availability-zones.html#concepts-available-regions) | `env` | **Yes** | `us-east-1` | | |||
| | `AmplifyAppId` | The unique ID for an Amplify app. For example, `d6a88fjhifqlks` | `secret env` | **Yes** | N/A | | |||
| | `BackendEnvARN` | The Amazon Resource Name (ARN) for a backend environment that is part of an Amplify app. | `secret env` | **Yes** | N/A | | |||
| | `GITHUB_TOKEN` | The GITHUB_TOKEN, required to post the comment with the preview URL | `github env` | **Yes** | N/A | | |||
There was a problem hiding this comment.
This field is not required, right? Please change **Yes** to No
There was a problem hiding this comment.
I was thinking of keeping it as a required field, what do you think? That way, the comments will come as default.
Either we keep it as optional, or I can update entrypoint.sh accordingly. Let me know what is to be done.
There was a problem hiding this comment.
I think keep it as an optional field would be better. Let others to decide if they want to show the preview link to public by themselves, instead of showing it mandatory.
There was a problem hiding this comment.
I've made the change. 45b4f56
update example and examples - remove 10 character trim
Totally loved your idea. Adding comment to the PR with the preview branch name:
Also I removed the 10 character limit on branch name.