Fixed Oracle SQL queries with IN condition and more than 1000 params
#14065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SilverFire
force-pushed
the
14062-oracle-in-conditions
branch
from
c3324f3 to
98a95a4
Compare
cebe
approved these changes
Apr 27, 2017
framework/db/oci/QueryBuilder.php
Outdated
| @@ -331,4 +331,56 @@ public function buildLikeCondition($operator, $operands, &$params) | |||
| } | |||
| return parent::buildLikeCondition($operator, $operands, $params); | |||
| } | |||
|
|
|||
| public function buildInCondition($operator, $operands, &$params) | |||
samdark
approved these changes
Apr 30, 2017
|
Merged f6a4f3c |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@samdark could you check whether this fix is applicable to #10371, or MSSQL limits parameters count per query?- checked. MSSQL problem is about bound parameters, not about number of params inin