Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

38 tumblr #39

Closed
wants to merge 2 commits into from
Closed

38 tumblr #39

wants to merge 2 commits into from

Conversation

xmrerx
Copy link

@xmrerx xmrerx commented Jul 30, 2015

No description provided.

@klimov-paul
Copy link
Member

Closed, see explanation at #38

@xmrerx xmrerx deleted the 38-tumblr branch July 30, 2015 08:31
@xmrerx
Copy link
Author

xmrerx commented Jul 30, 2015

Hello, Paul.

Could you please have a look at a few rows of changes in Oauth1 class:

  1. move $this->removeState('requestToken') to the place after the call of
    sendSignedRequest in fetchAccessToken method
  2. try to use it as a part of signature key to encrypt oauth_signature for
    fetching access token in the composeSignatureKey method

As for me it can make the Oauth1 class more flexible and will not broke the
previous logic. If not - sorry for bothering you.

On Thu, Jul 30, 2015 at 11:13 AM, Paul Klimov [email protected]
wrote:

Closed #39 #39.

—
Reply to this email directly or view it on GitHub
#39 (comment).

@klimov-paul
Copy link
Member

If you have a problem with OAuth1 class - open a separated issue to describe them in details.

@klimov-paul klimov-paul mentioned this pull request Aug 1, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xmrerx @klimov-paul