Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move parameters group into current route #128

Merged
merged 17 commits into from
Nov 22, 2021

Conversation

rustamwin
Copy link
Member

Q A
Is bugfix?
New feature?
Breaks BC? ✔️
Fixed issues #55

src/CurrentRouteInterface.php Outdated Show resolved Hide resolved
src/CurrentRoute.php Outdated Show resolved Hide resolved
tests/CurrentRouteTest.php Show resolved Hide resolved
@rustamwin rustamwin requested a review from a team November 15, 2021 15:28
src/CurrentRoute.php Outdated Show resolved Hide resolved
tests/CurrentRouteTest.php Outdated Show resolved Hide resolved
tests/CurrentRouteTest.php Outdated Show resolved Hide resolved
tests/CurrentRouteTest.php Outdated Show resolved Hide resolved
tests/CurrentRouteTest.php Outdated Show resolved Hide resolved
tests/CurrentRouteTest.php Outdated Show resolved Hide resolved
src/CurrentRoute.php Outdated Show resolved Hide resolved
Copy link
Member

@samdark samdark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think @roxblnfk is right about parameters vs arguments:

The term parameter (sometimes called formal parameter) is often used to refer to the variable as found in the function definition, while argument (sometimes called actual parameter) refers to the actual input supplied at function call.

i.e.

Parameter is variable in the declaration of function.
Argument is the actual value of this variable that gets passed to function.

src/CurrentRoute.php Outdated Show resolved Hide resolved
src/CurrentRoute.php Outdated Show resolved Hide resolved
src/CurrentRoute.php Outdated Show resolved Hide resolved
src/CurrentRoute.php Outdated Show resolved Hide resolved
@rustamwin rustamwin added status:under development Someone is working on a pull request. and removed status:code review The pull request needs review. labels Nov 18, 2021
@rustamwin rustamwin added status:ready for merge The pull request is OK to be merged. and removed status:under development Someone is working on a pull request. labels Nov 19, 2021
README.md Outdated Show resolved Hide resolved
@samdark samdark merged commit 42166eb into master Nov 22, 2021
@samdark samdark deleted the move-parameters-group-into-current-route branch November 22, 2021 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:ready for merge The pull request is OK to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants