Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused function #93

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Remove unused function #93

merged 1 commit into from
Oct 17, 2024

Conversation

MichaelChirico
Copy link
Contributor

No other reference to this function, and it's not exported:

https://github.com/search?q=repo%3Ayihui%2Fxfun%20%2Fpkg_update_one%2F&type=code

Copy link
Owner

@yihui yihui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I don't remember why I added this function now. It should be okay to remove it.

@yihui yihui merged commit 587e2a0 into yihui:main Oct 17, 2024
8 of 9 checks passed
@MichaelChirico MichaelChirico deleted the patch-2 branch October 17, 2024 22:03
@MichaelChirico
Copy link
Contributor Author

I'm also not sure! It was added unexported and not used anywhere at the time so it's not like it just became obsolete by accident:

e1b2408

I'm sure you had something truly marvelous in mind at the time, it just couldn't fit in the narrow margins of one commit 😉

@yihui
Copy link
Owner

yihui commented Oct 17, 2024

Haha, from my vague memory, perhaps I was doing some hack on win-builder because win-builder lacked the very latest version of a certain package.

Details

I used this function temporarily in the Authors@R field of DESCRIPTION to update win-builder's package. Don't tell the HiddenLayer guys, otherwise they'd claim that they found another "vulnerability" of R (arbitrary code execution in DESCRIPTION). Well, seriously, I have always thought Authors@R was a bad idea, but due the lack of support for recursive data structure in DCF, perhaps the evil eval() is the only way to go.

@MichaelChirico
Copy link
Contributor Author

That is indeed pretty devious 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants