Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove installed.packages() usage #91

Merged
merged 3 commits into from
Aug 29, 2024
Merged

Remove installed.packages() usage #91

merged 3 commits into from
Aug 29, 2024

Conversation

arnaudgallou
Copy link
Contributor

Closes #90

@CLAassistant
Copy link

CLAassistant commented Aug 29, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

yihui
yihui approved these changes Aug 29, 2024
View reviewed changes
Copy link
Owner

@yihui yihui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@yihui yihui merged commit 69d0411 into yihui:main Aug 29, 2024
9 checks passed
@arnaudgallou arnaudgallou deleted the fix/base-pkgs branch August 29, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yihui yihui yihui approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using installed.packages() to find base packages can be slow
3 participants
@arnaudgallou @CLAassistant @yihui