Karolinska Institutet theme #238
Conversation
|
I am uploading the logo to reference in the css here. |
|
Here's a preview of the theme:
|
| body { | ||
| font-family: system, -apple-system, ".SFNSText-Regular", "San Francisco", "Roboto", "Segoe UI", "Helvetica Neue", "Lucida Grande", sans-serif; | ||
| } | ||
|
|
||
| h1, h2, h3, h4, h5, h6 { | ||
| font-family: Cambria, "Hoefler Text", Utopia, "Liberation Serif", "Nimbus Roman No9 L Regular", Times, "Times New Roman", serif; | ||
| font-weight: 400; | ||
| } | ||
|
|
||
| .remark-code, .remark-inline-code { | ||
| font-family: Consolas, "Andale Mono WT", "Andale Mono", "Lucida Console", "Lucida Sans Typewriter", "DejaVu Sans Mono", "Bitstream Vera Sans Mono", "Liberation Mono", "Nimbus Mono L", Monaco, "Courier New", Courier, monospace; | ||
| } |
There was a problem hiding this comment.
-
Do you really need that many fonts?
-
Seems like you are missing the
@importcall to import the fonts?
There was a problem hiding this comment.
I think the font is fine. it doesn't import the fancy online fonts, the code will use whatever is found in the listed fonts.
There was a problem hiding this comment.
A valid concern is that the font appearance may not be consistent across different OS/browsers. I would suggest the same as @pat-s mentioned above, using the @import fonts.
An example from @emitanaka : https://github.com/emitanaka/ninja-theme/blob/master/docs/themes/kunoichi/assets/default-fonts.css
There was a problem hiding this comment.
I think the font is fine. it doesn't import the fancy online fonts, the code will use whatever is found in the listed fonts.
True, this might not be a practical problem but I see possible confusion for users questioning themselves if they need all these fonts to use the theme properly.
I also did that in the past but nowadays only use the fonts I also import 😄 . This makes it more clear what is happening.
There was a problem hiding this comment.
Test locally and looks great. Great work on the added demo.
If @ellessenne is ok with the current font setting then I think it's ready to merge.
| body { | ||
| font-family: system, -apple-system, ".SFNSText-Regular", "San Francisco", "Roboto", "Segoe UI", "Helvetica Neue", "Lucida Grande", sans-serif; | ||
| } | ||
|
|
||
| h1, h2, h3, h4, h5, h6 { | ||
| font-family: Cambria, "Hoefler Text", Utopia, "Liberation Serif", "Nimbus Roman No9 L Regular", Times, "Times New Roman", serif; | ||
| font-weight: 400; | ||
| } | ||
|
|
||
| .remark-code, .remark-inline-code { | ||
| font-family: Consolas, "Andale Mono WT", "Andale Mono", "Lucida Console", "Lucida Sans Typewriter", "DejaVu Sans Mono", "Bitstream Vera Sans Mono", "Liberation Mono", "Nimbus Mono L", Monaco, "Courier New", Courier, monospace; | ||
| } |
There was a problem hiding this comment.
A valid concern is that the font appearance may not be consistent across different OS/browsers. I would suggest the same as @pat-s mentioned above, using the @import fonts.
An example from @emitanaka : https://github.com/emitanaka/ninja-theme/blob/master/docs/themes/kunoichi/assets/default-fonts.css
|
Hi @pat-s and @tcgriffith, thanks for the feedback on this PR! Edit: |
* Added KI theme * Expanded title * <h*> tags have the same weight as body text * Added link to correct logo * Updated NEWS * Simplified font choice (it's now consistent across OSes) * More minor edits to style * Updated demo file
Hi,
I added a couple of css files for a theme following the Karolinska Institutet visual identity guidelines.
Thanks!
Alessandro