Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update required xfun version #2383

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Update required xfun version #2383

merged 1 commit into from
Nov 19, 2024

Conversation

MichaelChirico
Copy link
Contributor

As noted here:

35df6f8

The current {knitr} test suite assumes {xfun} >= 0.49

xfun::html_escape('"40"')
# [1] ""40""

Of course this is a behavior only in tests, so we don't technically need to bump the version; at a minimum we could put a branch in the test based on {xfun} version. But this approach seems fine + much simpler.

Copy link
Owner

@yihui yihui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@yihui yihui merged commit 4510c09 into yihui:master Nov 19, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants