-
-
Notifications
You must be signed in to change notification settings - Fork 878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Issue 2116] - New chunk option to add separators to subfloat environment #2140
Merged
Merged
Changes from 14 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
7098e25
The new separator is working for multiple plots
pedropark99 a5610fb
Run
pedropark99 c772bbe
Adjust comment that describes when the subfloat separator will be added
pedropark99 ac8eaf4
revert changes in Rd
yihui a7b4c6e
revert whitespace changes
yihui 87e2759
subfigsep -> subsep
yihui 624ddf3
delete an unnecessary file
yihui 01158c6
New prototype for vectors is ready, lets test it!
pedropark99 05620b0
Fix bug in if statement
pedropark99 2a6d6db
Change switch statement to correctly handle the three cases
pedropark99 c25f943
Everything is working now
pedropark99 aec619e
Update NEWS.md with new fig.subsep option
pedropark99 a1869a1
A new and more vectorised strategy for fig.subsep
pedropark99 5701694
Fix typo in comment
pedropark99 49c3f4d
Merge branch 'master' into 2116-subplot-sep
yihui 502f67a
assume that users read the documentation if they use the fig.subsep o…
yihui da4c28e
simplify the condition and message construction
yihui 1a350dd
merge the two if-statements
yihui 5edd018
I think the logic is simpler and clearer now
yihui File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is buggy when
n_subsep == fig.num - 1
, becausefig.cur
ranges from1
tofig.num
(whenfig.cur == fig.num
,subsep[fig.cur]
will be out of bound). For this case, we should conditionally addsubsep
tosub1
when!plot1
. I've fixed the problem in my changes.