fix(data): remove strict typing for optimistic false

Additional overload for `.add()` on NgRx Data Service causes issue when passing in `boolean` to `isOptimistic`. Remove overload as it should not be needed. Resolves ngrx#2928
yharaskrik · May 15, 2021 · b6a1760 · b6a1760
1 parent 045c4c3
commit b6a1760
Showing 1 changed file with 0 additions and 4 deletions.
diff --git a/modules/data/src/entity-services/entity-collection-service-base.ts b/modules/data/src/entity-services/entity-collection-service-base.ts
@@ -145,10 +145,6 @@ export class EntityCollectionServiceBase<
     entity: Partial<T>,
     options: EntityActionOptions & { isOptimistic: false }
   ): Observable<T>;
-  add(
-    entity: T,
-    options?: EntityActionOptions & { isOptimistic?: true }
-  ): Observable<T>;
   add(entity: T, options?: EntityActionOptions): Observable<T> {
     return this.dispatcher.add(entity, options);
   }